From: tjhunt <tjhunt>
Date: Tue, 20 Nov 2007 15:08:05 +0000 (+0000)
Subject: MDL-12133 - Errors calling parent::validation in a moodle form subclass because the... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=13ccb7bd589d046c2162a9d9b15720a8b106343b;p=moodle.git

MDL-12133 - Errors calling parent::validation in a moodle form subclass because the base class method returns true not an empty array. This patch allow subclasses to start their validate method with

$errors = parent::validation($data, $files);

which is what you naturally want to do if you are used to object oriented programming.

Merged from MOODLE_19_STABLE.
---

diff --git a/lib/formslib.php b/lib/formslib.php
index 0ad3809f93..f4285da203 100644
--- a/lib/formslib.php
+++ b/lib/formslib.php
@@ -511,10 +511,11 @@ class moodleform {
      *
      * @param array $data array of ("fieldname"=>value) of submitted data
      * @param array $files array of uploaded files "element_name"=>tmp_file_path
-     * @return bool array of errors or true if ok "element_name"=>"error_description"
+     * @return mixed an array of "element_name"=>"error_description" if there are errors.
+     *      true or an empty array if everything is OK.
      */
     function validation($data, $files) {
-        return true;
+        return array();
     }
 
     /**