From: tjhunt <tjhunt>
Date: Sun, 23 Nov 2008 11:53:21 +0000 (+0000)
Subject: unit test reliability: For some reason this does not work on my laptop. because the... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=1499ce318566d0a51a1ffe676835c2090afd8214;p=moodle.git

unit test reliability: For some reason this does not work on my laptop. because the standard function getrempteadr returns '', so just skip this test.
---

diff --git a/mod/quiz/simpletest/testaccessrules.php b/mod/quiz/simpletest/testaccessrules.php
index 72a57e55fb..2c767c80ed 100644
--- a/mod/quiz/simpletest/testaccessrules.php
+++ b/mod/quiz/simpletest/testaccessrules.php
@@ -43,15 +43,19 @@ class simple_rules_test extends MoodleUnitTestCase {
         $quiz = new stdClass;
         $attempt = new stdClass;
 
+        // Test the allowed case by getting the user's IP address. However, this
+        // does not always work, for example using the mac install package on my laptop.
         $quiz->subnet = getremoteaddr();
-        $quiz->questions = '';
-        $quizobj = new quiz($quiz, null, null);
-        $rule = new ipaddress_access_rule($quizobj, 0);
-        $this->assertFalse($rule->prevent_access());
-        $this->assertFalse($rule->description());
-        $this->assertFalse($rule->prevent_new_attempt(0, $attempt));
-        $this->assertFalse($rule->is_finished(0, $attempt));
-        $this->assertFalse($rule->time_left($attempt, 1));
+        if (!empty($quiz->subnet)) {
+            $quiz->questions = '';
+            $quizobj = new quiz($quiz, null, null);
+            $rule = new ipaddress_access_rule($quizobj, 0);
+            $this->assertFalse($rule->prevent_access());
+            $this->assertFalse($rule->description());
+            $this->assertFalse($rule->prevent_new_attempt(0, $attempt));
+            $this->assertFalse($rule->is_finished(0, $attempt));
+            $this->assertFalse($rule->time_left($attempt, 1));
+        }
 
         $quiz->subnet = '0.0.0.0';
         $quiz->questions = '';