From: poltawski Date: Thu, 7 Feb 2008 18:52:51 +0000 (+0000) Subject: MDL-13339 - ensure we don't continue the restore process if there is X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=175767ede79418a86a525342cf70c30972b1fc58;p=moodle.git MDL-13339 - ensure we don't continue the restore process if there is no course header in the backup file. This bug was causing blank course records to be created when users tried to restore a non-moodle backup file such as a scorm file. merged from MOODLE_19_STABLE --- diff --git a/backup/restorelib.php b/backup/restorelib.php index 1ba2c3297c..2c6fc07636 100644 --- a/backup/restorelib.php +++ b/backup/restorelib.php @@ -6812,6 +6812,11 @@ define('RESTORE_GROUPS_GROUPINGS', 3); $info = restore_read_xml_info ($xml_file); //Reading course_header from file $course_header = restore_read_xml_course_header ($xml_file); + + if(!is_object($course_header)){ + // ensure we fail if there is no course header + $course_header = false; + } } if (!defined('RESTORE_SILENTLY')) {