From: tjhunt <tjhunt>
Date: Fri, 17 Jul 2009 07:40:54 +0000 (+0000)
Subject: todochecker: don't match variables called $todo or fields called ->todo.
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=1c5648f169fc6001a5ad883cc2e9c38aad25c9b7;p=moodle.git

todochecker: don't match variables called $todo or fields called ->todo.
---

diff --git a/lib/simpletest/todochecker.php b/lib/simpletest/todochecker.php
index dbe026d42e..51799f68c2 100644
--- a/lib/simpletest/todochecker.php
+++ b/lib/simpletest/todochecker.php
@@ -110,7 +110,7 @@ function check_to_dos($filepath) {
     $lines = file($filepath);
     $matchesinfile = array();
     foreach ($lines as $lineno => $line) {
-        if (preg_match('/\bTODO\b/i', $line)) {
+        if (preg_match('/(?<!->|\$)\bTODO\b/i', $line)) {
             $matchesinfile[$lineno] = $line;
         }
     }