From: samhemelryk <samhemelryk>
Date: Fri, 26 Jun 2009 04:04:31 +0000 (+0000)
Subject: mod-resource MDL-16706 Removed inline JS and replaced with new PAGE methods
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=1d6b319b1148c79b5965e5fc5765d70ef14e2103;p=moodle.git

mod-resource MDL-16706 Removed inline JS and replaced with new PAGE methods
---

diff --git a/mod/resource/type/html/resource.class.php b/mod/resource/type/html/resource.class.php
index cadf8dfca8..76c6705c48 100644
--- a/mod/resource/type/html/resource.class.php
+++ b/mod/resource/type/html/resource.class.php
@@ -45,7 +45,7 @@ function _postprocess(&$resource) {
 
 
 function display() {
-    global $CFG;
+    global $CFG, $PAGE;
 
     $formatoptions = new object();
     $formatoptions->noclean = true;
@@ -96,11 +96,7 @@ function display() {
                         "", "", true, update_module_button($cm->id, $course->id, $this->strresource),
                         navmenu($course, $cm));
 
-                echo "\n<script type=\"text/javascript\">";
-                echo "\n//<![CDATA[\n";
-                echo "openpopup('/mod/resource/view.php?inpopup=true&id={$cm->id}','resource{$resource->id}','{$resource->popup}');\n";
-                echo "\n//]]>\n";
-                echo '</script>';
+                $PAGE->requires->js_function_call('openpopup', Array("/mod/resource/view.php?inpopup=true&id={$cm->id}","resource{$resource->id}",$resource->popup));
 
                 if (trim(strip_tags($resource->intro))) {
                     print_simple_box(format_module_intro('resource', $resource, $cm->id), "center");
diff --git a/mod/resource/type/text/resource.class.php b/mod/resource/type/text/resource.class.php
index 1cad6758e2..bfd6a8e88d 100644
--- a/mod/resource/type/text/resource.class.php
+++ b/mod/resource/type/text/resource.class.php
@@ -44,7 +44,7 @@ function _postprocess(&$resource) {
 }
 
 function display() {
-    global $CFG;
+    global $CFG, $PAGE;
 
     $formatoptions = new object();
     $formatoptions->noclean = true;
@@ -94,11 +94,7 @@ function display() {
                         "", "", true, update_module_button($cm->id, $course->id, $this->strresource),
                         navmenu($course, $cm));
 
-                echo "\n<script type=\"text/javascript\">";
-                echo "\n//<![CDATA[\n";
-                echo "openpopup('/mod/resource/view.php?inpopup=true&id={$cm->id}','resource{$resource->id}','{$resource->popup}');\n";
-                echo "\n//]]>\n";
-                echo '</script>';
+                $PAGE->requires->js_function_call('openpopup', Array("/mod/resource/view.php?inpopup=true&id={$cm->id}","resource{$resource->id}",$resource->popup));
 
                 if (trim(strip_tags($resource->intro))) {
                     print_simple_box(format_module_intro('resource', $resource, $cm->id), "center");