From: skodak <skodak>
Date: Mon, 22 Jan 2007 18:23:14 +0000 (+0000)
Subject: MDL-7861 fixed regression caused by one of previous commit related to print_single_bu... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=2463ef818f6772c91cb0aabbd8ea73d3b976a0f8;p=moodle.git

MDL-7861 fixed regression caused by one of previous commit related to print_single_button() and friends - old & handling restored, thanks Eloy for spotting the problem :-)
---

diff --git a/lib/weblib.php b/lib/weblib.php
index faa9956022..3452b3cc9b 100644
--- a/lib/weblib.php
+++ b/lib/weblib.php
@@ -2901,9 +2901,10 @@ function print_box_end($return=false) {
  */
 function print_single_button($link, $options, $label='OK', $method='get', $target='_self', $return=false) {
     $output = '';
+    $link = str_replace('"', '&quot;', $link); //basic XSS protection
     $output .= '<div class="singlebutton">';
     // taking target out, will need to add later target="'.$target.'"
-    $output .= '<form action="'. s($link) .'" method="'. $method .'">';   
+    $output .= '<form action="'. $link .'" method="'. $method .'">';   
     $output .= '<fieldset class="invisiblefieldset">';
     if ($options) {
         foreach ($options as $name => $value) {