From: skodak <skodak>
Date: Thu, 25 Jan 2007 18:17:57 +0000 (+0000)
Subject: MDL-8096 - fixed set_user_preference() weirdness, you could not pass $USER->id as... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=29c7e08328dfaf034f6f514e520d0b6e57f81d2b;p=moodle.git

MDL-8096 - fixed set_user_preference() weirdness, you could not pass $USER->id as $otheruser parameter
---

diff --git a/lib/moodlelib.php b/lib/moodlelib.php
index a6cb7004e8..b2416c670b 100644
--- a/lib/moodlelib.php
+++ b/lib/moodlelib.php
@@ -736,7 +736,7 @@ function set_user_preference($name, $value, $otheruser=NULL) {
 
     if ($preference = get_record('user_preferences', 'userid', $userid, 'name', $name)) {
         if (set_field('user_preferences', 'value', $value, 'id', $preference->id)) {
-            if (empty($otheruser) and !empty($USER)) {
+            if ($userid == $USER->id) {
                 $USER->preference[$name] = $value;
             }
             return true;
@@ -749,7 +749,7 @@ function set_user_preference($name, $value, $otheruser=NULL) {
         $preference->name   = $name;
         $preference->value  = (string)$value;
         if (insert_record('user_preferences', $preference)) {
-            if (empty($otheruser) and !empty($USER)) {
+            if ($userid == $USER->id) {
                 $USER->preference[$name] = $value;
             }
             return true;