From: tjhunt <tjhunt>
Date: Tue, 25 Aug 2009 19:09:04 +0000 (+0000)
Subject: outputlib MDL-20103 neater version of Jerome's fix.
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=2c5ec833bcfc4ec79b16fa9ee0cf9e23b5f2e84d;p=moodle.git

outputlib MDL-20103 neater version of Jerome's fix.
---

diff --git a/lib/outputrenderers.php b/lib/outputrenderers.php
index f906ee3703..7144e744a3 100644
--- a/lib/outputrenderers.php
+++ b/lib/outputrenderers.php
@@ -1005,10 +1005,8 @@ class moodle_core_renderer extends moodle_renderer_base {
         $lis = array();
         foreach ($items as $key => $string) {
             $item = $this->output_start_tag('li', array('class' => 'r' . $row));
-            if ($icons) {
-                if (key_exists($key, $icons)) { //test if the content has an assigned icon
-                    $item .= $this->output_tag('div', array('class' => 'icon column c0'), $icons[$key]);
-                }
+            if (!empty($icons[$key])) { //test if the content has an assigned icon
+                $item .= $this->output_tag('div', array('class' => 'icon column c0'), $icons[$key]);
             }
             $item .= $this->output_tag('div', array('class' => 'column c1'), $string);
             $item .= $this->output_end_tag('li');