From: skodak <skodak>
Date: Wed, 29 Apr 2009 20:58:06 +0000 (+0000)
Subject: MDL-13722, MDL-12909 - idnumber required in xml grade export, if not present do not... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=30f188f0b469890870fdb32a6f04f7ea071cf954;p=moodle.git

MDL-13722, MDL-12909 - idnumber required in xml grade export, if not present do not show user in export preview; merged from MOODEL_19_STABLE
---

diff --git a/grade/export/lib.php b/grade/export/lib.php
index 66680472ab..bd04f508d3 100755
--- a/grade/export/lib.php
+++ b/grade/export/lib.php
@@ -192,8 +192,9 @@ abstract class grade_export {
 
     /**
      * Prints preview of exported grades on screen as a feedback mechanism
+     * @param bool $require_user_idnumber true means skip users without idnumber
      */
-    public function display_preview() {
+    public function display_preview($require_user_idnumber=false) {
 
         print_heading(get_string('previewrows', 'grades'));
 
@@ -225,9 +226,10 @@ abstract class grade_export {
                 break;
             }
             $user = $userdata->user;
-            // if (empty($user->idnumber)) {   // Not sure why this was here, ccommented out for MDL-13722
-            //     continue;
-            // }
+            if ($require_user_idnumber and empty($user->idnumber)) {
+                // some exports require user idnumber
+                continue;
+            }
 
             $gradeupdated = false; // if no grade is update at all for this user, do not display this row
             $rowstr = '';
diff --git a/grade/export/xml/index.php b/grade/export/xml/index.php
index 764784c64c..3047a7eb8d 100755
--- a/grade/export/xml/index.php
+++ b/grade/export/xml/index.php
@@ -54,7 +54,7 @@ if ($data = $mform->get_data()) {
     // print the grades on screen for feedbacks
     $export->process_form($data);
     $export->print_continue();
-    $export->display_preview();
+    $export->display_preview(true);
     print_footer($course);
     exit;
 }