From: skodak <skodak>
Date: Tue, 18 Dec 2007 13:27:31 +0000 (+0000)
Subject: MDL-12517 null not treated properly, max instead of min typo and pretty please initia... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=379ea9493185b0b53a0e846f6f7de1ecad9c4310;p=moodle.git

MDL-12517 null not treated properly, max instead of min typo and pretty please initialize all objects properly; merged from MOODLE_19_STABLE
---

diff --git a/grade/report/grader/lib.php b/grade/report/grader/lib.php
index d5f93b63b1..51af47b800 100644
--- a/grade/report/grader/lib.php
+++ b/grade/report/grader/lib.php
@@ -199,15 +199,18 @@ class grade_report_grader extends grade_report {
                     $finalgrade = unformat_float($postedvalue);
                 }
 
-                // Warn if the grade is out of bounds.
                 $errorstr = '';
-                if ($finalgrade < $grade_item->grademax) {
+                // Warn if the grade is out of bounds.
+                if (is_null($finalgrade)) {
+                    // ok
+                } else if ($finalgrade < $grade_item->grademin) {
                     $errorstr = 'lessthanmin';
                 } else if ($finalgrade > $grade_item->grademax) {
                     $errorstr = 'morethanmax';
                 }
                 if ($errorstr) {
                     $user = get_record('user', 'id', $userid,'','','','','id, firstname, lastname');
+                    $gradestr = new object();
                     $gradestr->username = fullname($user);
                     $gradestr->itemname = $grade_item->get_name();
                     notify(get_string($errorstr, 'grades', $gradestr));