From: Penny Leach <penny@liip.ch>
Date: Wed, 18 Nov 2009 14:06:03 +0000 (+0000)
Subject: portfolio MDL-20894 better checking of no common formats
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=3ec8d78626b661ea060db9849a318f8c1a419967;p=moodle.git

portfolio MDL-20894 better checking of no common formats
---

diff --git a/lib/portfoliolib.php b/lib/portfoliolib.php
index 50b1b80a01..994edbf533 100644
--- a/lib/portfoliolib.php
+++ b/lib/portfoliolib.php
@@ -242,7 +242,9 @@ class portfolio_add_button {
             $linkoutput .= '&amp;instance=' . $instance->get('id');
         }
         else {
-            $selectoutput = portfolio_instance_select($this->instances, $this->formats, $this->callbackclass, 'instance', true);
+            if (!$selectoutput = portfolio_instance_select($this->instances, $this->formats, $this->callbackclass, 'instance', true)) {
+                return;
+            }
         }
 
         if (empty($addstr)) {