From: stronk7 <stronk7>
Date: Fri, 26 Jan 2007 21:19:07 +0000 (+0000)
Subject: Silly conditions produce silly results, please. :-P
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=4218c9b21ea1c038c42c1e7121ac73a34312696d;p=moodle.git

Silly conditions produce silly results, please. :-P
(WHERE 1 is not cross-db at all)
---

diff --git a/lib/db/upgrade.php b/lib/db/upgrade.php
index b5ae9f1e96..4688173e3b 100644
--- a/lib/db/upgrade.php
+++ b/lib/db/upgrade.php
@@ -479,7 +479,7 @@ function xmldb_main_upgrade($oldversion=0) {
         $result = $result && change_field_type($table, $field);
 
         /// For existing fields use 'name' as the 'shortname' entry
-        if ($fields = get_records_select('user_info_field', 1, '', 'id, name')) {
+        if ($fields = get_records_select('user_info_field', '', '', 'id, name')) {
             foreach ($fields as $field) {
                 $field->shortname = clean_param($field->name, PARAM_ALPHANUM);
                 $result && update_record('user_info_field', $field);