From: poltawski Date: Fri, 2 May 2008 10:48:54 +0000 (+0000) Subject: MDL-13716 - When storing progress of scorm activity a 404 is X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=45e94d82dd2c89d7101a8d9b88ab9e350fb432f3;p=moodle.git MDL-13716 - When storing progress of scorm activity a 404 is encountered and js failure on split. Cast to string to avoid this. thanks to Peter Chamberlin of LJCreate merged from MOODLE_19_STABLE --- diff --git a/mod/scorm/datamodels/scorm_12.js.php b/mod/scorm/datamodels/scorm_12.js.php index 6e5ceb0cdf..e95f396cad 100644 --- a/mod/scorm/datamodels/scorm_12.js.php +++ b/mod/scorm/datamodels/scorm_12.js.php @@ -544,7 +544,7 @@ function SCORMapi1_2() { var myRequest = NewHttpReq(); result = DoRequest(myRequest,"wwwroot) ?>/mod/scorm/datamodel.php","id=&sesskey=sesskey) ?>"+datastring); - results = result.split('\n'); + results = String(result).split('\n'); errorCode = results[1]; return results[0]; } diff --git a/mod/scorm/datamodels/scorm_13.js.php b/mod/scorm/datamodels/scorm_13.js.php index dba2a5795f..52784050f2 100644 --- a/mod/scorm/datamodels/scorm_13.js.php +++ b/mod/scorm/datamodels/scorm_13.js.php @@ -1120,7 +1120,7 @@ function SCORMapi1_3() { echo 'popupwin(result);'; } ?> - var results = result.split('\n'); + var results = String(result).split('\n'); if ((results.length > 2) && (navrequest != '')) { eval(results[2]); }