From: stronk7 <stronk7>
Date: Thu, 15 May 2008 17:03:49 +0000 (+0000)
Subject: prevent NULL contents before field change (old servers can have this wrongly defined... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=469dcbcc8b3fd627040d52fbad60491940007a1a;p=moodle.git

prevent NULL contents before field change (old servers can have this wrongly defined). MDL-14859 ; merged from 19_STABLE
---

diff --git a/lib/db/upgrade.php b/lib/db/upgrade.php
index 00f7dc37fb..2ade4db902 100644
--- a/lib/db/upgrade.php
+++ b/lib/db/upgrade.php
@@ -87,6 +87,11 @@ function xmldb_main_upgrade($oldversion=0) {
     if ($result && $oldversion < 2008051201) {
         notify('Increasing size of user idnumber field, this may take a while...', 'notifysuccess');
 
+    /// Under MySQL and Postgres... detect old NULL contents and change them by correct empty string. MDL-14859
+        if ($CFG->dbfamily == 'mysql' || $CFG->dbfamily == 'postgres') {
+            execute_sql("UPDATE {$CFG->prefix}user SET idnumber = '' WHERE idnumber IS NULL", true);
+        }
+
     /// Define index idnumber (not unique) to be dropped form user
         $table = new XMLDBTable('user');
         $index = new XMLDBIndex('idnumber');