From: skodak <skodak>
Date: Sun, 17 Feb 2008 19:04:01 +0000 (+0000)
Subject: MDL-12934 temporary fix for grade items of activities without proper course module... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=46d1af82f7d8c0376dda4e1c23212d13aaec780b;p=moodle.git

MDL-12934 temporary fix for grade items of activities without proper course module record; merged from MOODLE_19_STABLE
---

diff --git a/grade/lib.php b/grade/lib.php
index 2a3becfbee..2dd51eeb32 100644
--- a/grade/lib.php
+++ b/grade/lib.php
@@ -852,19 +852,18 @@ class grade_structure {
         $iteminstance = $element['object']->iteminstance;
 
         if ($withlink and $itemtype=='mod' and $iteminstance and $itemmodule) {
-            if (!$cm = get_coursemodule_from_instance($itemmodule, $iteminstance, $this->courseid)) {
-                continue;
-            }
+            if ($cm = get_coursemodule_from_instance($itemmodule, $iteminstance, $this->courseid)) {
 
-            $dir = $CFG->dirroot.'/mod/'.$itemmodule;
+                $dir = $CFG->dirroot.'/mod/'.$itemmodule;
 
-            if (file_exists($dir.'/grade.php')) {
-                $url = $CFG->wwwroot.'/mod/'.$itemmodule.'/grade.php?id='.$cm->id;
-            } else {
-                $url = $CFG->wwwroot.'/mod/'.$itemmodule.'/view.php?id='.$cm->id;
-            }
+                if (file_exists($dir.'/grade.php')) {
+                    $url = $CFG->wwwroot.'/mod/'.$itemmodule.'/grade.php?id='.$cm->id;
+                } else {
+                    $url = $CFG->wwwroot.'/mod/'.$itemmodule.'/view.php?id='.$cm->id;
+                }
 
-            $header = '<a href="'.$url.'">'.$header.'</a>';
+                $header = '<a href="'.$url.'">'.$header.'</a>';
+            }
         }
 
         return $header;