From: ericmerrill <ericmerrill>
Date: Thu, 8 Oct 2009 04:52:33 +0000 (+0000)
Subject: My Moodle/Courses: MDL-20472 get_my_courses returns 2 more courses then limit. Repair... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=4a09658ea8ac3457a799e73efd2576ceb46868bd;p=moodle.git

My Moodle/Courses: MDL-20472 get_my_courses returns 2 more courses then limit. Repairs two off by one errors in get_my_courses and get_user_courses_bycap.
---

diff --git a/lib/accesslib.php b/lib/accesslib.php
index a9bb580042..2feb7412fd 100755
--- a/lib/accesslib.php
+++ b/lib/accesslib.php
@@ -1281,10 +1281,12 @@ function get_user_courses_bycap($userid, $cap, $accessdata, $doanything, $sort='
             $c = make_context_subobj($c);
 
             if (has_capability_in_accessdata($cap, $c->context, $accessdata, $doanything)) {
-                $courses[] = $c;
-                if ($limit > 0 && $cc++ > $limit) {
+                if ($limit > 0 && $cc >= $limit) {
                     break;
                 }
+                
+                $courses[] = $c;
+                $cc++;
             }
         }
         $rs->close();
diff --git a/lib/datalib.php b/lib/datalib.php
index adfd7d777b..4301d6df15 100644
--- a/lib/datalib.php
+++ b/lib/datalib.php
@@ -926,10 +926,12 @@ function get_my_courses($userid, $sort='visible DESC,sortorder ASC', $fields=NUL
                 // build the context obj
                 $c = make_context_subobj($c);
 
-                $courses[$c->id] = $c;
-                if ($limit > 0 && $cc++ > $limit) {
+                if ($limit > 0 && $cc >= $limit) {
                     break;
                 }
+                
+                $courses[$c->id] = $c;
+                $cc++;
             }
             $rs->close();
             return $courses;