From: moodler Date: Tue, 3 Aug 2004 04:02:26 +0000 (+0000) Subject: Forum mail now logs differently if mail was just blocked (rather than X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=50a26903e6694e4fe1c5df003f282d095267dfc3;p=moodle.git Forum mail now logs differently if mail was just blocked (rather than flagging it as an error) --- diff --git a/mod/forum/lib.php b/mod/forum/lib.php index f8ec2f35a1..72db922bc9 100644 --- a/mod/forum/lib.php +++ b/mod/forum/lib.php @@ -298,10 +298,16 @@ function forum_cron () { $posttext = forum_make_mail_text($course, $forum, $discussion, $post, $userfrom, $userto); $posthtml = forum_make_mail_html($course, $forum, $discussion, $post, $userfrom, $userto); - if (! email_to_user($userto, $userfrom, $postsubject, $posttext, $posthtml, '', '', $CFG->forum_replytouser)) { - echo "Error: mod/forum/cron.php: Could not send out mail for id $post->id to user $userto->id ($userto->email) .. not trying again.\n"; - add_to_log($course->id, 'forum', 'mail error', "discuss.php?d=$discussion->id#$post->id", substr($post->subject,0,15), $cm->id, $userto->id); + if (!$mailresult = email_to_user($userto, $userfrom, $postsubject, $posttext, + $posthtml, '', '', $CFG->forum_replytouser)) { + echo "Error: mod/forum/cron.php: Could not send out mail for id $post->id to user $userto->id". + " ($userto->email) .. not trying again.\n"; + add_to_log($course->id, 'forum', 'mail error', "discuss.php?d=$discussion->id#$post->id", + substr($post->subject,0,30), $cm->id, $userto->id); $errorcount++; + } else if ($mailresult == 'emailstop') { + add_to_log($course->id, 'forum', 'mail blocked', "discuss.php?d=$discussion->id#$post->id", + substr($post->subject,0,30), $cm->id, $userto->id); } else { $mailcount++; } @@ -469,10 +475,13 @@ function forum_cron () { } $posthtml .= ''; - if (! email_to_user($userto, $site->shortname, $postsubject, $posttext, $posthtml, '', '', $CFG->forum_replytouser)) { + if (!$mailresult = email_to_user($userto, $site->shortname, $postsubject, $posttext, $posthtml, + '', '', $CFG->forum_replytouser)) { echo "ERROR!\n"; echo "Error: mod/forum/cron.php: Could not send out digest mail to user $userto->id ($userto->email)... not trying again.\n"; add_to_log($course->id, 'forum', 'mail digest error', '', '', $cm->id, $userto->id); + } else if ($mailresult == 'emailstop') { + add_to_log($course->id, 'forum', 'mail digest blocked', '', '', $cm->id, $userto->id); } else { echo "success.\n"; $usermailcount++;