From: martinlanghoff <martinlanghoff>
Date: Mon, 22 Jan 2007 05:32:14 +0000 (+0000)
Subject: mnet: remove extra paranoid check in the mnet xmlrpc client
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=56eec24397fdc672a6e062db5aa6c0a7eeda5bc7;p=moodle.git

mnet: remove extra paranoid check in the mnet xmlrpc client

 - Donal - this needs review. I don't think we can assume the remote
   end has the same service/method mappings we do. This will preclude
   us from using stuff we don't have installed the "server" code for
   but perhaps we do have the client code for.
---

diff --git a/mnet/xmlrpc/client.php b/mnet/xmlrpc/client.php
index 7fb22aacbe..fffb7cd10e 100644
--- a/mnet/xmlrpc/client.php
+++ b/mnet/xmlrpc/client.php
@@ -141,6 +141,10 @@ class mnet_xmlrpc_client {
             if (!empty($CFG->mnet_all_hosts_id)) {
                 $id_list .= ', '.$CFG->mnet_all_hosts_id;
             }
+
+            /*** TODO: Review MartinL notes - This is bogus AFAICT,
+             *** because we cannot be certain that the remote
+             *** host has the same plugins or modules we do
             // Find methods that we subscribe to on this host
             $sql = "
                 SELECT
@@ -161,6 +165,7 @@ class mnet_xmlrpc_client {
                 // TODO: Handle attempt to call not-permitted method
                 return false;
             }
+            *** END_OF_TODO */
 
         }
         $this->requesttext = xmlrpc_encode_request($this->method, $this->params);