From: pichetp Date: Thu, 4 Dec 2008 15:56:01 +0000 (+0000) Subject: MDL-17524 Deleting a calculated question delete datasetdefinitions shared by other... X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=57db70affbf247b50f0ca4f53c7bca444bece37b;p=moodle.git MDL-17524 Deleting a calculated question delete datasetdefinitions shared by other question --- diff --git a/question/type/calculated/questiontype.php b/question/type/calculated/questiontype.php index 72333f7a3e..685b9492c2 100644 --- a/question/type/calculated/questiontype.php +++ b/question/type/calculated/questiontype.php @@ -632,6 +632,10 @@ class question_calculated_qtype extends default_questiontype { $DB->delete_records("question_numerical_units", array("question" => $questionid)); if ($datasets = $DB->get_records('question_datasets', array('question' => $questionid))) { foreach ($datasets as $dataset) { + if (!$DB->get_records_select( + 'question_datasets', + "question != ? + AND datasetdefinition = ?;", array($questionid, $dataset->datasetdefinition))){ $DB->delete_records('question_dataset_definitions', array('id' => $dataset->datasetdefinition)); $DB->delete_records('question_dataset_items', array('definition' => $dataset->datasetdefinition)); }