From: piers <piers>
Date: Thu, 31 Jul 2008 22:16:30 +0000 (+0000)
Subject: MDL-15899 JavaScript error In IE7 when opening SCORM content in a new window.  Fix... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=61fa8a09dfeb5bc510a7cb126b0f3711c1eaf687;p=moodle.git

MDL-15899 JavaScript error In IE7 when opening SCORM content in a new window.  Fix spaces in popup name for fussy IE.
---

diff --git a/mod/scorm/player.php b/mod/scorm/player.php
index f6d9d543d6..9b69ebad09 100755
--- a/mod/scorm/player.php
+++ b/mod/scorm/player.php
@@ -325,7 +325,13 @@
 
             echo "                <iframe id=\"scoframe1\" class=\"scoframe\" name=\"scoframe1\" src=\"{$fullurl}\"></iframe>\n";   
         } else {
-?>
+            // Clean the name for the window as IE is fussy
+            $name = ereg_replace("[^A-Za-z0-9]", "", $scorm->name);
+            if (!$name) {
+                $name = 'DefaultPlayerWindow';
+            }
+            $name = 'scorm_'.$name;
+            ?>
                     <script type="text/javascript">
                     //<![CDATA[
 					scorm_resize();
@@ -350,7 +356,7 @@
                         url = "loadSCO.php?id=<?php echo $cm->id.$scoidpop ?>";
                         width = <?php p($scorm->width) ?>;
                         height = <?php p($scorm->height) ?>;
-                        var main = openpopup(url, "<?php p($scorm->name) ?>", "<?php p($scorm->options) ?>", width, height);
+                        var main = openpopup(url, "<?php p($name) ?>", "<?php p($scorm->options) ?>", width, height);
                    //]]>
                     </script>
                     <noscript>