From: pichetp <pichetp>
Date: Thu, 4 Dec 2008 16:04:48 +0000 (+0000)
Subject: MDL-17524 Deleting a calculated question delete datasetdefinitions shared by other... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=636bbc872842015357e7739fc7dd78d28a465e86;p=moodle.git

MDL-17524 Deleting a calculated question delete datasetdefinitions shared by other question
} missing...
---

diff --git a/question/type/calculated/questiontype.php b/question/type/calculated/questiontype.php
index 685b9492c2..7db4575546 100644
--- a/question/type/calculated/questiontype.php
+++ b/question/type/calculated/questiontype.php
@@ -636,8 +636,9 @@ class question_calculated_qtype extends default_questiontype {
                         'question_datasets',
                         "question != ?
                         AND datasetdefinition = ?;", array($questionid, $dataset->datasetdefinition))){                                 
-                $DB->delete_records('question_dataset_definitions', array('id' => $dataset->datasetdefinition));
-                $DB->delete_records('question_dataset_items', array('definition' => $dataset->datasetdefinition));
+                    $DB->delete_records('question_dataset_definitions', array('id' => $dataset->datasetdefinition));
+                    $DB->delete_records('question_dataset_items', array('definition' => $dataset->datasetdefinition));
+                }
             }
         }
         $DB->delete_records("question_datasets", array("question" => $questionid));