From: jamiesensei <jamiesensei>
Date: Sat, 12 Jan 2008 08:50:32 +0000 (+0000)
Subject: MDL-12695 Symantec Norton internet security pop up blocker seems to be stopping user... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=6923c5546a22616c0d638286aa4e75d6db74ead8;p=moodle.git

MDL-12695 Symantec Norton internet security pop up blocker seems to be stopping user starting a quiz attempt - fixed this by using print_single_button which uses an onclick event to trigger a confirm dialogue, should work better even with popup blockers.
---

diff --git a/mod/quiz/view.php b/mod/quiz/view.php
index df3aff401b..ac6a87514e 100644
--- a/mod/quiz/view.php
+++ b/mod/quiz/view.php
@@ -399,14 +399,16 @@
             if ($unfinished) {
                 $strconfirmstartattempt = '';
             } else if ($quiz->timelimit && $quiz->attempts) {
-                $strconfirmstartattempt = addslashes(get_string('confirmstartattempttimelimit','quiz', $quiz->attempts));
+                $strconfirmstartattempt = get_string('confirmstartattempttimelimit','quiz', $quiz->attempts);
             } else if ($quiz->timelimit) {
-                $strconfirmstartattempt = addslashes(get_string('confirmstarttimelimit','quiz'));
+                $strconfirmstartattempt = get_string('confirmstarttimelimit','quiz');
             } else if ($quiz->attempts) {
-                $strconfirmstartattempt = addslashes(get_string('confirmstartattemptlimit','quiz', $quiz->attempts));
+                $strconfirmstartattempt = get_string('confirmstartattemptlimit','quiz', $quiz->attempts);
             } else {
                 $strconfirmstartattempt =  '';
             }
+            // Determine the URL to use.
+            $attempturl = "attempt.php?id=$cm->id";
 
             // Prepare options depending on whether the quiz should be a popup.
             if (!empty($quiz->popup)) {
@@ -415,22 +417,20 @@
                         "width='+window.screen.width+', channelmode=yes, fullscreen=yes, " .
                         "scrollbars=yes, resizeable=no, directories=no, toolbar=no, " .
                         "titlebar=no, location=no, status=no, menubar=no";
+	            if (!empty($CFG->usesid) && !isset($_COOKIE[session_name()])) {
+	                $attempturl = sid_process_url($attempturl);
+	            }
+	            
+	            echo '<input type="button" value="'.$buttontext.'" onclick="javascript:';
+	            if ($strconfirmstartattempt) {
+	            	$strconfirmstartattempt = addslashes($strconfirmstartattempt);
+	                echo "if (confirm('".addslashes_js($strconfirmstartattempt)."')) ";
+	            } 
+	            echo "window.open('$attempturl','$window','$windowoptions');", '" />';   
             } else {
-                $window = '_self';
-                $windowoptions = '';
+            	print_single_button("attempt.php", array('id'=>$cm->id), $buttontext, 'get', '', false, '', false, $strconfirmstartattempt);
             }
 
-            // Determine the URL to use.
-            $attempturl = "attempt.php?id=$cm->id";
-            if (!empty($CFG->usesid) && !isset($_COOKIE[session_name()])) {
-                $attempturl = sid_process_url($attempturl);
-            }
-            
-            echo '<input type="button" value="'.$buttontext.'" onclick="javascript:';
-            if ($strconfirmstartattempt) {
-                echo "if (confirm('".addslashes_js($strconfirmstartattempt)."')) ";
-            } 
-            echo "window.open('$attempturl','$window','$windowoptions');", '" />';   
 
 ?>
 <noscript>