From: martinlanghoff <martinlanghoff>
Date: Wed, 19 Sep 2007 07:52:27 +0000 (+0000)
Subject: course/lib: print_course() fix bug when $course->managers was not set
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=6b4d8c4d587c8d7f65970c9df19150da5b6fe1f8;p=moodle.git

course/lib: print_course() fix bug when $course->managers was not set

Fix a thinko in a variable assignment that prevented us from grabbing
the correct roles as managers. Addresses Yu's report at
MDL-11182 admin shows up as teacher.
---

diff --git a/course/lib.php b/course/lib.php
index 7597df2fe5..76f3a7a89b 100644
--- a/course/lib.php
+++ b/course/lib.php
@@ -1820,8 +1820,8 @@ function print_course($course) {
     
     /// first find all roles that are supposed to be displayed
     
-    if ($managerroles = !empty($CFG->coursemanager)) {
-        $coursemanagerroles = split(',', $managerroles);
+    if (!empty($CFG->coursemanager)) {
+        $managerroles = split(',', $CFG->coursemanager);
         $canseehidden = has_capability('moodle/role:viewhiddenassigns', $context);
         $namesarray = array();
         if (isset($course->managers)) {
@@ -1838,7 +1838,7 @@ function print_course($course) {
                 }
             }
         } else {
-            $rusers = get_role_users($coursemanagerroles, $context, 
+            $rusers = get_role_users($managerroles, $context, 
                                      true, '', 'r.sortorder ASC, u.lastname ASC', $canseehidden);
             if (is_array($rusers) && count($rusers)) {
                 $canviewfullnames = has_capability('moodle/site:viewfullnames', $context);