From: tjhunt <tjhunt>
Date: Fri, 10 Jul 2009 03:30:43 +0000 (+0000)
Subject: setup: Need memory before setup_DB.
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=6c77145468ee5a56bef36a33575ae0c7c543c5e0;p=moodle.git

setup: Need memory before setup_DB.

I was getting an interesting failure with $CFG->prefix commented
out in config.php (by mistake!). Abbreviated stack trace
lib/setup.php -> setup_DB -> dml_exception('prefixcannotbeempty') ->
  get_string -> string_manager->__construct -> get_plugin_types

That loads lib.php from every module, which runs out of memeory.
---

diff --git a/lib/setup.php b/lib/setup.php
index 286718b400..66339af6ef 100644
--- a/lib/setup.php
+++ b/lib/setup.php
@@ -262,11 +262,11 @@ global $SCRIPT;
 /// make sure PHP is not severly misconfigured
     setup_validate_php_configuration();
 
-/// Connect to the database
-    setup_DB();
-
 /// Increase memory limits if possible
-    raise_memory_limit('96M');    // We should never NEED this much but just in case...
+    //raise_memory_limit('96M');    // We should never NEED this much but just in case...
+
+    /// Connect to the database
+    setup_DB();
 
 /// Disable errors for now - needed for installation when debug enabled in config.php
     if (isset($CFG->debug)) {