From: David Mudrak <david.mudrak@gmail.com>
Date: Mon, 4 Jan 2010 18:15:24 +0000 (+0000)
Subject: Parameter consistency check
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=6cbc6c5d9af082c660065076606ed3e64b0987a1;p=moodle.git

Parameter consistency check
---

diff --git a/mod/workshop/editform.php b/mod/workshop/editform.php
index b211f8afb2..dc7b0ffc0b 100644
--- a/mod/workshop/editform.php
+++ b/mod/workshop/editform.php
@@ -54,6 +54,11 @@ $mform = $strategy->get_edit_strategy_form($PAGE->url);
 if ($mform->is_cancelled()) {
     redirect($workshop->view_url());
 } elseif ($data = $mform->get_data()) {
+    if (($data->workshopid != $workshop->id) or ($data->strategy != $workshop->strategy)) {
+        // this may happen if someone changes the workshop setting while the user had the
+        // editing form opened
+        throw new invalid_parameter_exception('Invalid workshop ID or the grading strategy has changed.');
+    }
     $strategy->save_edit_strategy_form($data);
     if (isset($data->saveandclose)) {
         redirect($workshop->view_url());