From: iarenaza <iarenaza>
Date: Sat, 15 Nov 2008 12:27:26 +0000 (+0000)
Subject: file resources: MDL-14541 Object tag embedding PDF's and nested Flash objects does... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=7045cfaa025fb3708086b6d546e496af11197263;p=moodle.git

file resources: MDL-14541 Object tag embedding PDF's and nested Flash objects does not work reliably

Merged from MOODLE_19_STABLE.

Credit goes to David Boyer for reporting and suggesting the fix for PDF files,
and Jon Witts & Mauno Korpelainen for proving a way to reproduce the Flash
issue and tips to fix it.
---

diff --git a/mod/resource/type/file/resource.class.php b/mod/resource/type/file/resource.class.php
index 34f71268a7..5816aefa7d 100644
--- a/mod/resource/type/file/resource.class.php
+++ b/mod/resource/type/file/resource.class.php
@@ -643,12 +643,14 @@ class resource_file extends resource_base {
                 echo '<param name="loop" value="true" />';
                 echo '<param name="controller" value="true" />';
                 echo '<param name="scale" value="aspect" />';
+                echo '<param name="base" value="." />';
                 echo '<!--[if !IE]>-->';
                 echo "<object type=\"application/x-shockwave-flash\" data=\"$fullurl\">";
                 echo '<param name="controller" value="true" />';
                 echo '<param name="autoplay" value="true" />';
                 echo '<param name="loop" value="true" />';
                 echo '<param name="scale" value="aspect" />';
+                echo '<param name="base" value="." />';
                 echo '<!--<![endif]-->';
                 echo '<a href="' . $fullurl . '">' . $fullurl . '</a>';
                 echo '<!--[if !IE]>-->';
@@ -665,6 +667,7 @@ class resource_file extends resource_base {
             } elseif ($resourcetype == 'pdf') {
                 echo '<div class="resourcepdf">';
                 echo '<object data="' . $fullurl . '" type="application/pdf">';
+                echo '<param name="src" value="' . $fullurl . '" />';
                 echo get_string('clicktoopen', 'resource') . '<a href="' . $fullurl . '">' . format_string($resource->name) . '</a>';
                 echo '</object>';
                 echo '</div>';