From: jerome <jerome>
Date: Tue, 30 Jun 2009 02:42:56 +0000 (+0000)
Subject: report MDL-19660 fix  PHP Fatal error when display report (wrong field order into... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=72c6b04ae708d4acf057c45537fec00d0628fdc6;p=moodle.git

report MDL-19660 fix  PHP Fatal error when display report (wrong field order into get_users_by_capability) - bug only in 2.0
---

diff --git a/course/report/log/lib.php b/course/report/log/lib.php
index 2fc2acd9c5..c91ac2520f 100644
--- a/course/report/log/lib.php
+++ b/course/report/log/lib.php
@@ -309,12 +309,12 @@ function print_log_selector_form($course, $selecteduser=0, $selecteddate='today'
     $users = array();
 
     if ($course->id != SITEID) {
-        $courseusers = get_users_by_capability($context, 'moodle/course:view', '', 'lastname ASC, firstname ASC', '','u.id, u.firstname, u.lastname, u.idnumber',$selectedgroup,null, false);
-    } else {
+        $courseusers = get_users_by_capability($context, 'moodle/course:view', 'u.id, u.firstname, u.lastname, u.idnumber', 'lastname ASC, firstname ASC', '','',$selectedgroup,null, false);
+} else {
         // this may be a lot of users :-(
         $courseusers = $DB->get_records('user', array('deleted'=>0), 'lastaccess DESC', 'id, firstname, lastname, idnumber');
     }
-    
+   
     if (count($courseusers) < COURSE_MAX_USERS_PER_DROPDOWN && !$showusers) {
         $showusers = 1;
     }