From: mjollnir_ <mjollnir_>
Date: Wed, 17 Nov 2004 05:05:14 +0000 (+0000)
Subject: Merge from MOODLE_14_STABLE: moodle--eduforge--1.3.3--patch-201 - optimized calls... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=72ccca56323a6711dbfc4233d89a670893f592cb;p=moodle.git

Merge from MOODLE_14_STABLE: moodle--eduforge--1.3.3--patch-201 - optimized calls to get_courses() to retrieve only required fields (martinlanghoff)
---

diff --git a/course/category.php b/course/category.php
index 4a5e1c46cb..4f1c13b006 100644
--- a/course/category.php
+++ b/course/category.php
@@ -168,7 +168,7 @@
             $movecourse = NULL;
             $swapcourse = NULL;
 
-            $courses = get_courses($category->id);
+            $courses = get_courses($category->id,'c.sortorder ASC', 'c.id,c.sortorder');
 
             if (isset($moveup)) {
                 if ($movecourse = get_record("course", "id", $moveup)) {
diff --git a/course/index.php b/course/index.php
index 085a50cbd9..3a6f3a315f 100644
--- a/course/index.php
+++ b/course/index.php
@@ -245,7 +245,7 @@
     }
 
 /// Find any orphan courses that don't yet have a valid category and set to default
-    if ($courses = get_courses()) {
+    if ($courses = get_courses(NULL,NULL,'c.category,c.id,c.sortorder')) {
         foreach ($courses as $course) {
             if ($course->category and !isset($categories[$course->category])) {
                 set_field("course", "category", $default, "id", $course->id);
diff --git a/course/lib.php b/course/lib.php
index a29ccde8e8..af3f705043 100644
--- a/course/lib.php
+++ b/course/lib.php
@@ -1149,7 +1149,7 @@ function print_category_info($category, $depth) {
     echo "\n\n".'<table border="0" cellpadding="3" cellspacing="0" width="100%">';
 
     if ($CFG->frontpage == FRONTPAGECOURSELIST) {
-        $courses = get_courses($category->id);
+        $courses = get_courses($category->id, NULL, 'c.id,c.sortorder,c.visible,c.fullname,c.shortname,c.password,c.summary');
 
         echo "<tr>";
 
@@ -1224,14 +1224,14 @@ function print_courses($category, $width="100%") {
         $categories = get_categories(0);  // Parent = 0   ie top-level categories only
         if (count($categories) == 1) {
             $category   = array_shift($categories);
-            $courses    = get_courses($category->id);
+            $courses    = get_courses($category->id, NULL, 'c.id,c.sortorder,c.visible,c.fullname,c.shortname,c.password,c.summary');
         } else {
-            $courses    = get_courses("all");
+            $courses    = get_courses("all", NULL, 'c.id,c.sortorder,c.visible,c.fullname,c.shortname,c.password,c.summary');
         }
         unset($categories);
     } else {
         $categories = get_categories($category->id);  // sub categories
-        $courses    = get_courses($category->id);
+        $courses    = get_courses($category->id, NULL, 'c.id,c.sortorder,c.visible,c.fullname,c.shortname,c.password,c.summary');
     }
 
     if ($courses) {