From: tjhunt <tjhunt>
Date: Thu, 5 Apr 2007 13:54:20 +0000 (+0000)
Subject: MDL-9224 - Score sometimes relealed, even when the quiz settings say it should not... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=7d014bf58251fb0cf4f03f58af906bf29835ba55;p=moodle.git

MDL-9224 - Score sometimes relealed, even when the quiz settings say it should not be. Merged from OU Moodle.
---

diff --git a/mod/quiz/locallib.php b/mod/quiz/locallib.php
index d2e545997d..014ff457bf 100644
--- a/mod/quiz/locallib.php
+++ b/mod/quiz/locallib.php
@@ -727,8 +727,10 @@ function quiz_get_combined_reviewoptions($quiz, $attempts, $context=null) {
     }
     foreach ($attempts as $attempt) {
         $attemptoptions = quiz_get_reviewoptions($quiz, $attempt, $context);
-        $someoptions->$field = $someoptions->$field || $attemptoptions->$field;
-        $alloptions->$field = $someoptions->$field && $attemptoptions->$field;
+        foreach ($fields as $field) {
+            $someoptions->$field = $someoptions->$field || $attemptoptions->$field;
+            $alloptions->$field = $alloptions->$field && $attemptoptions->$field;
+        }
     }
     return array($someoptions, $alloptions);
 }