From: dongsheng <dongsheng>
Date: Mon, 20 Jul 2009 07:08:02 +0000 (+0000)
Subject: "MDL-13766, allow null value saved in options"
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=7d6ca931f3aa85c67703bf209a79517f09acb101;p=moodle.git

"MDL-13766, allow null value saved in options"
---

diff --git a/repository/lib.php b/repository/lib.php
index dca6f42bd5..e37aee0e9b 100644
--- a/repository/lib.php
+++ b/repository/lib.php
@@ -1359,15 +1359,8 @@ abstract class repository {
         $result = true;
         foreach ($options as $name=>$value) {
             if ($id = $DB->get_field('repository_instance_config', 'id', array('name'=>$name, 'instanceid'=>$this->id))) {
-                if ($value===null) {
-                    $result = $result && $DB->delete_records('repository_instance_config', array('name'=>$name, 'instanceid'=>$this->id));
-                } else {
-                    $result = $result && $DB->set_field('repository_instance_config', 'value', $value, array('id'=>$id));
-                }
+                $result = $result && $DB->set_field('repository_instance_config', 'value', $value, array('id'=>$id));
             } else {
-                if ($value===null) {
-                    return true;
-                }
                 $config = new object();
                 $config->instanceid = $this->id;
                 $config->name   = $name;