From: Petr Skoda <skodak@moodle.org>
Date: Thu, 19 Nov 2009 18:11:14 +0000 (+0000)
Subject: MDL-20901 fixed input validation
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=7e7089e3595b9325c92f0b8e5499362132daee8e;p=moodle.git

MDL-20901 fixed input validation
---

diff --git a/backup/backup.php b/backup/backup.php
index 4a89ac7b91..1ee0ed3b5f 100644
--- a/backup/backup.php
+++ b/backup/backup.php
@@ -119,7 +119,7 @@
     raise_memory_limit("192M");
 
     //Call the form, depending the step we are
-    if (!$launch) {
+    if (!$launch or !data_submitted() or !confirm_sesskey()) {
         // if we're at the start, clear the cache of prefs
         if (isset($SESSION->backupprefs[$course->id])) {
             unset($SESSION->backupprefs[$course->id]);
diff --git a/backup/backup_check.html b/backup/backup_check.html
index 368a20b18c..853a099280 100644
--- a/backup/backup_check.html
+++ b/backup/backup_check.html
@@ -50,6 +50,7 @@
 <form id="form" method="post" action="backup.php">
 <table cellpadding="5" style="text-align:center;margin-left:auto;margin-right:auto">
 <?php
+    echo '<input type="hidden" name="sesskey" value="'.sesskey().'" />';
 
     if (empty($to)) {
         //Now print the Backup Name tr
diff --git a/backup/backup_form.html b/backup/backup_form.html
index 20c0a38825..e13e31cd98 100644
--- a/backup/backup_form.html
+++ b/backup/backup_form.html
@@ -124,6 +124,8 @@ function selectItemInCheckboxByName(formId, checkName, checked ) {
 <form id="form1" method="post" action="backup.php">
 <table cellpadding="5" style="margin-left:auto;margin-right:auto;">
 <?php
+    echo '<input type="hidden" name="sesskey" value="'.sesskey().'" />';
+
 /// Acummulator for hidden options and proper XHTML output
     $hidden_options = '';
     //Now, check modules and info and show posibilities