From: moodler <moodler>
Date: Mon, 22 Mar 2004 02:57:27 +0000 (+0000)
Subject: Fix from Bernard Boucher for situation when no groups members defined
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=840c178193d2b378140f8a41c3abc7cb52723002;p=moodle.git

Fix from Bernard Boucher for situation when no groups members defined

   http://moodle.org/mod/forum/discuss.php?d=6335#29657
---

diff --git a/mod/survey/lib.php b/mod/survey/lib.php
index 64ad234cd6..0af4a67ef4 100644
--- a/mod/survey/lib.php
+++ b/mod/survey/lib.php
@@ -189,16 +189,17 @@ function survey_get_responses($surveyid, $groupid) {
     global $CFG;
 
     if ($groupid) {
+        $groupsdb = ", {$CFG->prefix}groups_members AS gm";
         $groupsql = "AND gm.groupid = $groupid AND u.id = gm.userid";
     } else {
+        $groupsdb = "";
         $groupsql = "";
     }
 
     return get_records_sql("SELECT MAX(a.time) as time, 
                                    u.id, u.firstname, u.lastname, u.picture
                               FROM {$CFG->prefix}survey_answers AS a, 
-                                   {$CFG->prefix}user AS u,
-                                   {$CFG->prefix}groups_members AS gm
+                                   {$CFG->prefix}user AS u   $groupsdb
                              WHERE a.survey = $surveyid 
                                    AND a.userid = u.id $groupsql
                           GROUP BY u.id, u.firstname, u.lastname