From: stronk7 <stronk7>
Date: Tue, 27 Jan 2009 17:50:12 +0000 (+0000)
Subject: MDL-17365 forum rate - validate rating against scale values. Merged from 19_STABLE
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=84e00f89598a86d7b3d0ef75d60d4f43c30e086c;p=moodle.git

MDL-17365 forum rate - validate rating against scale values. Merged from 19_STABLE
---

diff --git a/mod/forum/rate.php b/mod/forum/rate.php
index 1879f4d34b..0f7a1240f7 100644
--- a/mod/forum/rate.php
+++ b/mod/forum/rate.php
@@ -40,6 +40,9 @@
 
         $discussionid = false;
 
+    /// Calculate scale values
+        $scale_values = make_grades_menu($forum->scale);
+
         foreach ((array)$data as $postid => $rating) {
             if (!is_numeric($postid)) {
                 continue;
@@ -63,6 +66,11 @@
                 }
             }
 
+        /// Check rate is valid for for that forum scale values
+            if (!array_key_exists($rating, $scale_values) && $rating != FORUM_UNSET_POST_RATING) {
+                print_error('invalidrate', 'forum', '', $rating);
+            }
+
             if ($rating == FORUM_UNSET_POST_RATING) {
                 $DB->delete_records('forum_ratings', array('post' => $postid, 'userid' => $USER->id));
                 forum_update_grades($forum, $post->userid);