From: moodler <moodler>
Date: Mon, 30 Oct 2006 03:57:08 +0000 (+0000)
Subject: Merge better gradebookroles default from stable
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=8a2cb2fa8d94cb48eb1f5022bed49595e870220e;p=moodle.git

Merge better gradebookroles default from stable
---

diff --git a/lib/adminlib.php b/lib/adminlib.php
index 2ba3573033..9d21ca9dee 100644
--- a/lib/adminlib.php
+++ b/lib/adminlib.php
@@ -2313,12 +2313,18 @@ class admin_setting_special_gradebookroles extends admin_setting {
         $visiblename = get_string('gradebookroles', 'admin');
         $description = get_string('configgradebookroles', 'admin');
 
-        parent::admin_setting($name, $visiblename, $description, '');
+        $default = $this->get_setting;
+
+        if (empty($default)) {
+            $default = array(5);    // The student role in a default install
+        }
+
+        parent::admin_setting($name, $visiblename, $description, $default);
     }
 
     function get_setting() {
         global $CFG;
-        if (isset($CFG->{$this->name})) {
+        if (!empty($CFG->{$this->name})) {
             return explode(',', $CFG->{$this->name});
         } else {
             $value = array();