From: moodler <moodler>
Date: Thu, 25 Nov 2004 10:01:56 +0000 (+0000)
Subject: Changes for XHTML and accessibility compatibility
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=8ac17ba443b0296467cdeb4d5d8101ea86c5aa81;p=moodle.git

Changes for XHTML and accessibility compatibility
---

diff --git a/mod/quiz/lib.php b/mod/quiz/lib.php
index d90ebe3043..47e507337d 100644
--- a/mod/quiz/lib.php
+++ b/mod/quiz/lib.php
@@ -1043,7 +1043,7 @@ function quiz_print_quiz_questions($quiz, $questions,
     // $readonly determines if it is an attempt or an review,
     // The condition used here is unfortunatelly somewhat confusing...
     $readonly = !empty($results) && !isset($results->attemptbuildsonthelast)
-            ? ' readonly="readonly" ' : '';
+            ? ' disabled="disabled" ' : '';
 
     foreach ($questions as $question) {
 
diff --git a/mod/quiz/questiontypes/multianswer/questiontype.php b/mod/quiz/questiontypes/multianswer/questiontype.php
index fb89a42ff5..fb5a2650a2 100644
--- a/mod/quiz/questiontypes/multianswer/questiontype.php
+++ b/mod/quiz/questiontypes/multianswer/questiontype.php
@@ -271,7 +271,7 @@ class quiz_embedded_cloze_qtype extends quiz_default_questiontype {
                                 ? ' selected="selected" ' : '';
                         $outputoptions .= "<option value=\"$mcanswer->id\" $selected>$mcanswer->answer</option>";
                     }
-                   echo "<select $popup $style name=\"$inputname\" $readonly>";
+                   echo "<select $popup $style name=\"$inputname\">";
                    echo $outputoptions;
                    echo '</select>';
                    break;
diff --git a/mod/quiz/questiontypes/multichoice/questiontype.php b/mod/quiz/questiontypes/multichoice/questiontype.php
index a1c3ba99e8..8a3ea96ddb 100644
--- a/mod/quiz/questiontypes/multichoice/questiontype.php
+++ b/mod/quiz/questiontypes/multichoice/questiontype.php
@@ -204,10 +204,7 @@ class quiz_multichoice_qtype extends quiz_default_questiontype {
                 $checked = !empty($question->response[$nameprefix.$aid])
                         ? ' checked="checked" ' : '';
             }
-            if ($readonly) {
-                $readonly = ' readonly="readonly" disabled="disabled" ';
-            }
-            echo "<input $readonly $name $checked $type  value=\"$answer->id\" />";
+            echo "<input $readonly $name $checked $type  value=\"$answer->id\" alt=\"".s($answer->answer)."\" />";
            
             echo "</td>";
             
diff --git a/mod/quiz/questiontypes/shortanswer/questiontype.php b/mod/quiz/questiontypes/shortanswer/questiontype.php
index f314d53494..663d0de147 100644
--- a/mod/quiz/questiontypes/shortanswer/questiontype.php
+++ b/mod/quiz/questiontypes/shortanswer/questiontype.php
@@ -124,7 +124,7 @@ class quiz_shortanswer_qtype extends quiz_default_questiontype {
 
         if ($quiz->feedback && isset($answers[$nameprefix])
                 && $feedback = $answers[$nameprefix]->feedback) {
-           quiz_print_comment("<p align=\"right\">$feedback</p>");
+           quiz_print_comment($feedback);
         }
         if ($readonly && $quiz->correctanswers) {
             $delimiter = '';
diff --git a/mod/quiz/questiontypes/truefalse/questiontype.php b/mod/quiz/questiontypes/truefalse/questiontype.php
index a53abb9adb..df7692aba8 100644
--- a/mod/quiz/questiontypes/truefalse/questiontype.php
+++ b/mod/quiz/questiontypes/truefalse/questiontype.php
@@ -122,9 +122,6 @@ class quiz_truefalse_qtype extends quiz_default_questiontype {
         } else if ($false->id == $question->response[$nameprefix]) {
            $falsechecked = 'checked="checked"';
         }
-        if ($readonly) {
-            $readonly = ' readonly="readonly" disabled="disabled" ';
-        }
 
         $truecorrect = "";
         $falsecorrect = "";
@@ -137,16 +134,16 @@ class quiz_truefalse_qtype extends quiz_default_questiontype {
            }
         }
         $inputname = ' name="'.$nameprefix.'" ';
-        echo "<table align=\"right\" cellpadding=\"5\"><tr><td align=\"right\">$stranswer:&nbsp;&nbsp;";
+        echo "<table align=\"right\" cellpadding=\"5\"><tr><td align=\"right\">$stranswer:&nbsp;&nbsp;</td>";
         echo "<td $truecorrect>";
-        echo "<input $truechecked type=\"radio\" $readonly $inputname value=\"$true->id\" />$true->answer";
+        echo "<input $truechecked type=\"radio\" $readonly $inputname value=\"$true->id\" alt=\"".s($true->answer)."\" />$true->answer";
         echo "</td><td $falsecorrect>";
-        echo "<input $falsechecked type=\"radio\"  $readonly $inputname value=\"$false->id\" />$false->answer";
+        echo "<input $falsechecked type=\"radio\"  $readonly $inputname value=\"$false->id\" alt=\"".s($false->answer)."\" />$false->answer";
         echo "</td></tr></table><br clear=\"all\" />";// changed from clear=ALL jm
         if ($quiz->feedback && isset($answers[$nameprefix])
                 && $feedback = $answers[$nameprefix]->feedback) {
            quiz_print_comment(
-                    "<p align=\"right\">$feedback</p>");
+                    "$feedback");
         }
     }