From: moodler <moodler>
Date: Thu, 19 Feb 2004 17:54:32 +0000 (+0000)
Subject: Don't bug out when sort not specified
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=8e4c9ef7b157c40191d7be0417ee20562e32edab;p=moodle.git

Don't bug out when sort not specified
---

diff --git a/lib/datalib.php b/lib/datalib.php
index 6248ee52e5..51ef76f53a 100644
--- a/lib/datalib.php
+++ b/lib/datalib.php
@@ -1127,13 +1127,16 @@ function get_course_students($courseid, $sort="s.timeaccess", $dir="", $page=0,
         $select .= " AND u.id = gm.userid AND gm.groupid = '$group'";
     }
 
+    if ($sort) {
+        $sort = " ORDER BY $sort ";
+    }
+
     return get_records_sql("SELECT u.id, u.username, u.firstname, u.lastname, u.maildisplay, u.mailformat,
                             u.email, u.city, u.country, u.lastlogin, u.picture, u.department, u.institution,
                             u.lang, u.timezone, s.timeaccess as lastaccess
                             FROM {$CFG->prefix}user u, 
                                  {$CFG->prefix}user_students s $groupmembers
-                            WHERE $select
-                            ORDER BY $sort $dir $limit");
+                            WHERE $select $sort $dir $limit");
 }
 
 /**