From: tjhunt <tjhunt>
Date: Tue, 12 Dec 2006 08:58:53 +0000 (+0000)
Subject: MDL-7602 - Multianswer question type only works with invalid HTML. Merged from MOODLE... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=9016b062e71fe757d6de1b701a1cde07e31ecb87;p=moodle.git

MDL-7602 - Multianswer question type only works with invalid HTML. Merged from MOODLE_17_STABLE.
---

diff --git a/question/type/multianswer/questiontype.php b/question/type/multianswer/questiontype.php
index e3e546ce1f..c23b2f50c7 100644
--- a/question/type/multianswer/questiontype.php
+++ b/question/type/multianswer/questiontype.php
@@ -311,7 +311,12 @@ class embedded_cloze_qtype extends default_questiontype {
                                 ? ' selected="selected" ' : '';
                         $outputoptions .= "<option value=\"$mcanswer->id\" $selected>$mcanswer->answer</option>";
                     }
-                   echo "<select $popup $disabled $style name=\"$inputname\">";
+                   // In the next line, $readonly is invalid HTML, but it works in
+                   // all browsers. $disabled would be valid, but then the JS for
+                   // displaying the feedback does not work. Of course, we should
+                   // not be relying on JS (for accessibility reasons), but that is
+                   //a bigger problem.
+                   echo "<select $popup $readonly $style name=\"$inputname\">";
                    echo $outputoptions;
                    echo '</select>';
                    if (!empty($feedback) && $USER->screenreader) {