From: skodak <skodak>
Date: Thu, 8 Oct 2009 10:57:20 +0000 (+0000)
Subject: MDL-12886 minor improvement in return value validation
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=960dc298571c42ef589797094760a01caad703a3;p=moodle.git

MDL-12886 minor improvement in return value validation
---

diff --git a/webservice/rest/simpleserver.php b/webservice/rest/simpleserver.php
index 7b8b81a591..cb435233a5 100644
--- a/webservice/rest/simpleserver.php
+++ b/webservice/rest/simpleserver.php
@@ -115,7 +115,9 @@ class webservice_rest_server extends webservice_base_server {
     protected function send_response() {
         $this->send_headers();
         $xml = '<?xml version="1.0" encoding="UTF-8" ?>'."\n";
+        $xml .= '<RESPONSE>'."\n";
         $xml .= self::xmlize_result($this->returns, $this->function->returns_desc);
+        $xml .= '</RESPONSE>'."\n";
         echo $xml;
     }
 
@@ -177,7 +179,7 @@ class webservice_rest_server extends webservice_base_server {
             foreach ($desc->keys as $key=>$subdesc) {
                 if (!array_key_exists($key, $returns)) {
                     if ($subdesc->rewquired) {
-                        // TODO: Huston, we have a problem! maybe we should better throw coding_exception
+                        $single .= '<ERROR>Missing key</ERROR>';
                         continue;
                     } else {
                         //optional field