From: David Mudrak <david.mudrak@gmail.com>
Date: Mon, 4 Jan 2010 18:16:41 +0000 (+0000)
Subject: Methods to get info about assessments and dimensions are part of strategy API
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=9df08ee8944b8bf25b5e500fab3cdac6d6c052a0;p=moodle.git

Methods to get info about assessments and dimensions are part of strategy API
---

diff --git a/mod/workshop/eval/best/lib.php b/mod/workshop/eval/best/lib.php
index f2777e2588..5e6103fe84 100644
--- a/mod/workshop/eval/best/lib.php
+++ b/mod/workshop/eval/best/lib.php
@@ -67,10 +67,10 @@ class workshop_best_evaluation implements workshop_evaluation {
         }
 
         // get the information about the assessment dimensions
-        $diminfo = $grader->eval_best_dimensions_info();
+        $diminfo = $grader->get_dimensions_info();
 
         // fetch a recordset with all assessments to process
-        $rs         = $grader->eval_best_get_assessments_recordset($restrict);
+        $rs         = $grader->get_assessments_recordset($restrict);
         $batch      = array();    // will contain a set of all assessments of a single submission
         $previous   = null;       // a previous record in the recordset
         foreach ($rs as $current) {
diff --git a/mod/workshop/form/accumulative/lib.php b/mod/workshop/form/accumulative/lib.php
index 1b549dae71..41a44eec48 100644
--- a/mod/workshop/form/accumulative/lib.php
+++ b/mod/workshop/form/accumulative/lib.php
@@ -270,7 +270,7 @@ class workshop_accumulative_strategy implements workshop_strategy {
      * @param resource $restrict 
      * @return TODO
      */
-    public function eval_best_get_assessments_recordset($restrict) {
+    public function get_assessments_recordset($restrict) {
         global $DB;
 
         $sql = 'SELECT s.id AS submissionid,
@@ -302,7 +302,7 @@ class workshop_accumulative_strategy implements workshop_strategy {
      *
      * @return array [dimid] => stdClass (->id ->max ->min ->weight)
      */
-    public function eval_best_dimensions_info() {
+    public function get_dimensions_info() {
         global $DB;
 
         $sql = 'SELECT d.id, d.grade, d.weight, s.scale
diff --git a/mod/workshop/form/lib.php b/mod/workshop/form/lib.php
index 9760947713..0f6400771d 100644
--- a/mod/workshop/form/lib.php
+++ b/mod/workshop/form/lib.php
@@ -93,4 +93,23 @@ interface workshop_strategy {
      */
     public function supports_evaluation(workshop_evaluation $evaluation);
 
+    /**
+     * Returns a general information about the assessment dimensions
+     *
+     * @return array [dimid] => stdClass (->id ->max ->min ->weight)
+     */
+    public function get_dimensions_info();
+
+    /**
+     * Returns recordset with detailed information of all assessments done using this strategy
+     *
+     * The returned structure must be a recordset of objects containing at least properties:
+     * submissionid, assessmentid, assessmentweight, reviewerid, gradinggrade, dimensionid and grade.
+     * It is possible to pass user id(s) of reviewer(s). Then, the method returns just the reviewer's
+     * assessments info.
+     *
+     * @param array|int|null $restrict optional id or ids of the reviewer
+     * @return moodle_recordset
+     */
+    public function get_assessments_recordset($restrict=null);
 }
diff --git a/mod/workshop/form/rubric/lib.php b/mod/workshop/form/rubric/lib.php
index e4c57d2b3f..12cabcb930 100644
--- a/mod/workshop/form/rubric/lib.php
+++ b/mod/workshop/form/rubric/lib.php
@@ -320,7 +320,7 @@ class workshop_rubric_strategy implements workshop_strategy {
      * @param array|int|null $restrict optional id or ids of the reviewer
      * @return moodle_recordset
      */
-    public function eval_best_get_assessments_recordset($restrict=null) {
+    public function get_assessments_recordset($restrict=null) {
         global $DB;
 
         $sql = 'SELECT s.id AS submissionid,
@@ -354,7 +354,7 @@ class workshop_rubric_strategy implements workshop_strategy {
      *
      * @return array [dimid] => stdClass (->id ->max ->min ->weight)
      */
-    public function eval_best_dimensions_info() {
+    public function get_dimensions_info() {
         global $DB;
 
         $sql = 'SELECT d.id AS id, MIN(l.grade) AS min, MAX(l.grade) AS max, 1 AS weight