From: danmarsden <danmarsden>
Date: Tue, 13 May 2008 00:41:34 +0000 (+0000)
Subject: MDL-12037 - backup does not report errors correctly in backup_module()
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=a0127802d3a623da0bee7a56d5b4da62110ba3b7;p=moodle.git

MDL-12037 - backup does not report errors correctly in backup_module()
---

diff --git a/backup/backuplib.php b/backup/backuplib.php
index ea51459223..690693fd7a 100644
--- a/backup/backuplib.php
+++ b/backup/backuplib.php
@@ -2247,6 +2247,7 @@
         global $CFG;
 
         $status = true;
+        $statusm = true;
 
         require_once($CFG->dirroot.'/mod/'.$module.'/backuplib.php');
 
@@ -2256,7 +2257,13 @@
             if (function_exists($onemodbackup)) {
                 foreach ($preferences->mods[$module]->instances as $instance => $object) {
                     if (!empty($object->backup)) {
-                        $status = $onemodbackup($bf,$preferences,$instance);
+                        $statusm = $onemodbackup($bf,$preferences,$instance);
+                        if (!$statusm) {
+                            if (!defined('BACKUP_SILENTLY')) {
+                                notify('backup of '.$module.'-'.$object->name.' failed.');
+                            }
+                            $status = false;
+                        }
                     }
                 }
             }  else {