From: samhemelryk Date: Tue, 30 Jun 2009 08:33:29 +0000 (+0000) Subject: messages MDL-19664 Clean up the messages javascript code X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=a1b53dcf3f97f33e390df6ffebc2195d69ba1f1a;p=moodle.git messages MDL-19664 Clean up the messages javascript code I have cleaned up the message Javascript code, implementing the new PAGE methods and at the same time implemented the new OUTPUT methods --- diff --git a/message/discussion.php b/message/discussion.php index 6be0c0acbb..1dd60c35a0 100644 --- a/message/discussion.php +++ b/message/discussion.php @@ -23,9 +23,11 @@ } if ($user->deleted) { - print_header(); - print_heading(get_string('userdeleted')); - print_footer(); + $PAGE->set_generaltype('popup'); + $PAGE->set_title(get_string('discussion', 'message').': '.fullname($user)); + echo $OUTPUT->header(); + echo $OUTPUT->heading(get_string('userdeleted'), 1); + echo $OUTPUT->footer(); die; } @@ -128,7 +130,10 @@ $userfullname = fullname($user); $mefullname = fullname($USER); - print_header(get_string('discussion', 'message').': '.fullname($user), '', '', 'edit-message'); + $PAGE->set_generaltype('popup'); + $PAGE->set_title(get_string('discussion', 'message').': '.fullname($user)); + echo $OUTPUT->header(); + echo '
'; echo '
'; echo print_user_picture($user, SITEID, $user->picture, 48, true, true, 'userwindow'); @@ -219,10 +224,10 @@ $fullname = $userfullname; } - if ($message->format == FORMAT_HTML){ - $printmessage = format_text($message->fullmessagehtml, $message->format, $options, 0); + if ($message->fullmessageformat == FORMAT_HTML){ + $printmessage = format_text($message->fullmessagehtml, $message->fullmessageformat, $options, 0); } else{ - $printmessage = format_text($message->fullmessage, $message->format, $options, 0); + $printmessage = format_text($message->fullmessage, $message->fullmessageformat, $options, 0); } $printmessage = '
'.$fullname.' '. '['.$time.']: '. @@ -241,10 +246,10 @@ foreach ($messages as $message) { $time = userdate($message->timecreated, get_string('strftimedatetimeshort')); - if ($message->format == FORMAT_HTML){ - $printmessage = format_text($message->fullmessagehtml, $message->format, $options, 0); + if ($message->fullmessageformat == FORMAT_HTML){ + $printmessage = format_text($message->fullmessagehtml, $message->fullmessageformat, $options, 0); } else{ - $printmessage = format_text($message->fullmessage, $message->format, $options, 0); + $printmessage = format_text($message->fullmessage, $message->fullmessageformat, $options, 0); } $printmessage = '
'.$mefullname.' '. '['.$time.']: '. @@ -264,10 +269,10 @@ foreach ($messages as $message) { $time = userdate($message->timecreated, get_string('strftimedatetimeshort')); - if ($message->format == FORMAT_HTML){ - $printmessage = format_text($message->fullmessagehtml, $message->format, $options, 0); + if ($message->fullmessageformat == FORMAT_HTML){ + $printmessage = format_text($message->fullmessagehtml, $message->fullmessageformat, $options, 0); } else{ - $printmessage = format_text($message->fullmessage, $message->format, $options, 0); + $printmessage = format_text($message->fullmessage, $message->fullmessageformat, $options, 0); } $printmessage = '
'.$userfullname.' '. '['.$time.']: '. @@ -337,5 +342,5 @@ echo '
'; - print_footer('none'); + echo $OUTPUT->footer(); ?> diff --git a/message/edit.php b/message/edit.php index 491dd6d49f..10ba691c4e 100644 --- a/message/edit.php +++ b/message/edit.php @@ -269,8 +269,6 @@ echo ""; - -/// Finish with a footer - print_footer($course); + $OUTPUT->footer(); ?> diff --git a/message/history.php b/message/history.php index c955af4985..8942b6dfd9 100644 --- a/message/history.php +++ b/message/history.php @@ -14,6 +14,8 @@ print_error('disabled', 'message'); } + $PAGE->set_title(get_string('messagehistory', 'message')); + /// Script parameters $userid1 = required_param('user1', PARAM_INT); if (! $user1 = $DB->get_record("user", array("id"=>$userid1))) { // Check it's correct @@ -21,9 +23,9 @@ } if ($user1->deleted) { - print_header(); - print_heading(get_string('userdeleted').': '.$userid1); - print_footer(); + echo $OUTPUT->header(); + echo $OUTPUT->heading(get_string('userdeleted').': '.$userid1, 1); + echo $OUTPUT->footer(); die; } @@ -33,9 +35,9 @@ print_error('invaliduserid'); } if ($user2->deleted) { - print_header(); - print_heading(get_string('userdeleted').': '.$userid2); - print_footer(); + echo $OUTPUT->header(); + echo $OUTPUT->heading(get_string('userdeleted').': '.$userid2, 1); + echo $OUTPUT->footer(); die; } } else { @@ -48,11 +50,11 @@ /// Our two users are defined - let's set up the page - print_header(get_string('messagehistory', 'message'), '', '', '', ''); + echo $OUTPUT->header(); /// Print out a heading including the users we are looking at - print_simple_box_start('center'); + echo $OUTPUT->box_start('center'); echo ''; echo ''; echo '
'; echo print_user_picture($user1, SITEID, $user1->picture, 100, true, true, 'userwindow').'
'; @@ -67,7 +69,7 @@ echo fullname($user2); echo '
'; - print_simple_box_end(); + echo $OUTPUT->box_end(); /// Get all the messages and print them @@ -85,7 +87,7 @@ $current->month = $date['month']; $current->year = $date['year']; echo ''; - print_heading(userdate($message->timecreated, $blockdate), 'center', 4); + echo $OUTPUT->heading(userdate($message->timecreated, $blockdate), 4, 'center'); } if ($message->useridfrom == $user1->id) { echo message_format_message($message, $user1, $messagedate, $search, 'other'); @@ -94,9 +96,9 @@ } } } else { - print_heading(get_string('nomessagesfound', 'message')); + echo $OUTPUT->heading(get_string('nomessagesfound', 'message'), 1); } - print_footer('none'); + echo $OUTPUT->footer(); ?> diff --git a/message/index.php b/message/index.php index b207c6bf65..84fa9d5ec8 100644 --- a/message/index.php +++ b/message/index.php @@ -24,7 +24,8 @@ /// Popup a window if required and quit (usually from external links). if ($popup) { - print_header(); + $PAGE->set_generaltype('popup'); + $OUTPUT->header(); echo $PAGE->requires->js_function_call('openpopup', Array('/message/index.php', 'message', 'menubar=0,location=0,scrollbars,status,resizable,width=400,height=500', 0))->asap(); redirect("$CFG->wwwroot/", '', 0); exit; @@ -51,12 +52,12 @@ /// Header on this page if ($tab == 'contacts') { - print_header(get_string('messages', 'message').' - '.format_string($SITE->fullname), '', '', '', - ''); - } else { - print_header(get_string('messages', 'message').' - '.format_string($SITE->fullname)); + $PAGE->set_periodic_refresh_delay($CFG->message_contacts_refresh); } + $PAGE->set_generaltype('popup'); + $PAGE->set_title(get_string('messages', 'message').' - '.format_string($SITE->fullname)); + echo $OUTPUT->header(); echo ''; echo ''; @@ -88,6 +89,6 @@ } echo '
'; - print_footer('none'); + echo $OUTPUT->footer(); ?> diff --git a/message/lib.php b/message/lib.php index 19ef75bf4c..9bd4edd941 100644 --- a/message/lib.php +++ b/message/lib.php @@ -149,11 +149,16 @@ function message_print_contacts() { $autorefresh = '

'.get_string('pagerefreshes', 'message', $CFG->message_contacts_refresh).'

'; $autorefresh = addslashes_js($autorefresh); // js escaping - echo $PAGE->requires->js_function_call('document.write', Array($autorefresh))->asap(); - // gracefully degrade JS autorefresh - echo '
'; echo ''; if (!empty($CFG->messagewasjustemailed)) { - notify(get_string('mailsent', 'message'), 'notifysuccess'); + $OUTPUT->notifcation(get_string('mailsent', 'message'), 'notifysuccess'); } echo ''; $PAGE->requires->js_function_call('set_focus', Array('edit-message')); - print_footer('empty'); + echo $OUTPUT->footer(); } ?> diff --git a/message/user.php b/message/user.php index a722392002..478770140f 100644 --- a/message/user.php +++ b/message/user.php @@ -49,7 +49,9 @@ message_unblock_contact($unblockcontact); } - print_header('','','','','',false,'','',false,''); + //$PAGE->set_title('Message History'); + $PAGE->set_generaltype('popup'); + echo $OUTPUT->header(); echo ''; echo ''; @@ -57,18 +59,6 @@ echo '
'.fullname($user).'
'; - //echo '
'; /// Print login status of this user - //if ($user->lastaccess) { - // if (time() - $user->lastaccess > $CFG->message_offline_time) { - // echo get_string('offline', 'message').': '.format_time(time() - $user->lastaccess); - // } else { - // echo get_string('lastaccess').': '.get_string('ago', 'message', format_time(time() - $user->lastaccess)); - // } - //} else { - // echo get_string("lastaccess").":". get_string("never"); - //} - //echo ''; - echo '
'; if ($contact = $DB->get_record('message_contacts', array('userid'=>$USER->id, 'contactid'=>$user->id))) { if ($contact->blocked) { @@ -87,6 +77,6 @@ echo '
'; echo print_user_picture($user, SITEID, $user->picture, true, true, true, 'userwindow').'
'; - print_footer('empty'); + echo $OUTPUT->footer(); ?> diff --git a/theme/standard/styles_layout.css b/theme/standard/styles_layout.css index 80c0cf7119..fc694c9c3e 100644 --- a/theme/standard/styles_layout.css +++ b/theme/standard/styles_layout.css @@ -2873,6 +2873,20 @@ body#message-edit th { padding-left: 20px; } +body.message .messagejsautorefresh { + display:none; +} +body.message .messagejsmanualrefresh { + display:block; +} +body.jsenabled .messagejsautorefresh { + display:block; +} +body.jsenabled .messagejsmanualrefresh { + display:none; +} + + /*** *** Notes ***/