From: tjhunt Date: Tue, 16 Jun 2009 10:23:56 +0000 (+0000) Subject: blocks upgrade: MDL-19511 put back important code that Petr commented out! X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=a26146d563eea1d0c54e94200389ad402910c73c;p=moodle.git blocks upgrade: MDL-19511 put back important code that Petr commented out! The actual mistake was the name of the previous column, which is totally irrelevant, but which XMLDB had filled in incorrectly. Grrr! --- diff --git a/lib/db/upgrade.php b/lib/db/upgrade.php index 05dbd154e3..b2d3bbf4ea 100644 --- a/lib/db/upgrade.php +++ b/lib/db/upgrade.php @@ -1796,16 +1796,15 @@ WHERE gradeitemid IS NOT NULL AND grademax IS NOT NULL"); } if ($result && $oldversion < 2009050607) { -//TODO: remove, this field does not exist yet! /// Changing precision of field defaultregion on table block_instances to (16) -/* $table = new xmldb_table('block_instances'); - $field = new xmldb_field('defaultregion', XMLDB_TYPE_CHAR, '16', null, XMLDB_NOTNULL, null, null, 'subpagepattern'); + $table = new xmldb_table('block_instances'); + $field = new xmldb_field('defaultregion', XMLDB_TYPE_CHAR, '16', null, XMLDB_NOTNULL, null, null, 'pagetype'); /// Launch change of precision for field defaultregion $dbman->change_field_precision($table, $field); /// Main savepoint reached - upgrade_main_savepoint($result, 2009050607);*/ + upgrade_main_savepoint($result, 2009050607); } if ($result && $oldversion < 2009050608) {