From: skodak <skodak>
Date: Sun, 24 Sep 2006 19:10:13 +0000 (+0000)
Subject: fix for MDL-6680 redirect function is broken when running php as CGI, me() now used... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=aade3a4b6a0fc06408be4506b58cbadd724b4946;p=moodle.git

fix for MDL-6680 redirect function is broken when running php as CGI, me() now used instead of SCRIPT_NAME + minor coding style changes
---

diff --git a/lib/weblib.php b/lib/weblib.php
index c717f2f19a..2861d4af85 100644
--- a/lib/weblib.php
+++ b/lib/weblib.php
@@ -4673,28 +4673,26 @@ function redirect($url, $message='', $delay=-1) {
         // the absolute path. (In practice browsers accept relative 
         // paths - but still, might as well do it properly.)
         // This code turns relative into absolute. 
-        if(!preg_match('/^[a-z]+:/',$url)) { 
+        if (!preg_match('|^[a-z]+:|', $url)) { 
             // Get host name http://www.wherever.com
-            $hostpart=preg_replace('/^(.*?[^:\/])\/.*$/','$1',$CFG->wwwroot);
-            if(preg_match('/^\//',$url)) {
-                // URLs beginning with / are relative to web server root so
-                // we just add them in
-                $url=$hostpart.$url;
+            $hostpart = preg_replace('|^(.*?[^:/])/.*$|', '$1', $CFG->wwwroot);
+            if (preg_match('|^/|', $url)) {
+                // URLs beginning with / are relative to web server root so we just add them in
+                $url = $hostpart.$url;
             } else {
-                // URLs not beginning with / are relative to path of current
-                // script, so add that on.
-                $url=$hostpart.rtrim(dirname($_SERVER['SCRIPT_NAME']),'/\\').'/'.$url;
+                // URLs not beginning with / are relative to path of current script, so add that on.
+                $url = $hostpart.me().'/../'.$url;
             }
             // Replace all ..s
-            while(true) {
-                $newurl=preg_replace('/\/[^\/]*\/\.\.\//','/',$url);
-                if($newurl==$url) {
+            while (true) {
+                $newurl = preg_replace('|/[^/]*/\.\./|', '/', $url);
+                if ($newurl == $url) {
                     break;
                 }
-                $url=$newurl;
+                $url = $newurl;
             }
         }
-        
+
         $delay = 0;
         //try header redirection first
         @header('HTTP/1.x 303 See Other'); //302 might not work for POST requests, 303 is ignored by obsolete clients