From: tjhunt <tjhunt>
Date: Mon, 24 Nov 2008 04:55:57 +0000 (+0000)
Subject: role assign: Don't get duplicate records in potential_assignees_below_course user... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=abfc0304e1cb538421dc8ad792ca475ffcda5980;p=moodle.git

role assign: Don't get duplicate records in potential_assignees_below_course user selector
---

diff --git a/admin/roles/lib.php b/admin/roles/lib.php
index 647c508d25..517de9886a 100644
--- a/admin/roles/lib.php
+++ b/admin/roles/lib.php
@@ -1006,8 +1006,8 @@ class potential_assignees_below_course extends role_assign_user_selector_base {
         }
         $roleids =  '('.implode(',', $validroleids).')';
 
-        $fields      = 'SELECT ' . $this->required_fields_sql('u');
-        $countfields = 'SELECT COUNT(1)';
+        $fields      = 'SELECT DISTINCT ' . $this->required_fields_sql('u');
+        $countfields = 'SELECT COUNT(DISTINCT u.id)';
 
         $sql   = " FROM {user} u
                    JOIN {role_assignments} ra ON ra.userid = u.id