From: stronk7 <stronk7> Date: Wed, 24 Jan 2007 17:54:53 +0000 (+0000) Subject: Prevent rename_field() to be executed if no full specs of X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=bb3172c03814a7a2c8eefcf38c030333a7e62d73;p=moodle.git Prevent rename_field() to be executed if no full specs of the original field are provided. MDL-8296 --- diff --git a/lib/ddllib.php b/lib/ddllib.php index affb26a074..34a168cb94 100644 --- a/lib/ddllib.php +++ b/lib/ddllib.php @@ -896,6 +896,12 @@ function rename_field($table, $field, $newname, $continue=true, $feedback=true) return false; } +/// Check we have included full field specs + if (!$field->getType()) { + debugging('Field ' . $field->getName() . ' must contain full specs. Rename skipped', DEBUG_DEVELOPER); + return false; + } + /// Check field isn't id. Renaming over that field is not allowed if ($field->getName() == 'id') { debugging('Field ' . $field->getName() . ' cannot be renamed. Rename skipped', DEBUG_DEVELOPER);