From: skodak <skodak>
Date: Thu, 25 May 2006 10:00:06 +0000 (+0000)
Subject: Bug #5416 - sorting by question column in overview report plugin broken - please... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=be41c836913cba7f7505db37697d22ccd759ec05;p=moodle.git

Bug #5416 - sorting by question column in overview report plugin broken - please test; merged from MOODLE_16_STABLE
---

diff --git a/mod/quiz/report/overview/report.php b/mod/quiz/report/overview/report.php
index 98f7eebe6c..a6fe18ed27 100644
--- a/mod/quiz/report/overview/report.php
+++ b/mod/quiz/report/overview/report.php
@@ -308,7 +308,7 @@ class quiz_report extends quiz_default_report {
                         if(!$questionsort) {
                             $qid          = intval(substr($sortpart, 1));
                             $select .= ', grade ';
-                            $from        .= 'LEFT JOIN '.$CFG->prefix.'question_sessions qns ON qns.attemptid = qa.attemptuniqueid '.
+                            $from        .= ' LEFT JOIN '.$CFG->prefix.'question_sessions qns ON qns.attemptid = qa.id '.
                                                 'LEFT JOIN '.$CFG->prefix.'question_states qs ON qs.id = qns.newgraded ';
                             $where       .= ' AND ('.sql_isnull('qns.questionid').' OR qns.questionid = '.$qid.')';
                             $newsort[]    = 'grade '.(strpos($sortpart, 'ASC')? 'ASC' : 'DESC');