From: jamiesensei Date: Wed, 24 Sep 2008 09:10:43 +0000 (+0000) Subject: MDL-16632 "green highlighting should not be applied to grading method in quiz respons... X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=bfcaf5e684bb8e737bd113e39b8e06e9b45aaca9;p=moodle.git MDL-16632 "green highlighting should not be applied to grading method in quiz responses report form" Ooops. We do need highlighting on the reponses report. The responses page does have a grade displayed that needs highlighting. I was looking at an ungraded quiz. Need highlighting to highlight grade of graded attempt. Reverted earlier patch and instead using a different colour for highlighting graded grade. Now using light yellow with a darker yellow border instead of green which is used in reports to highlight the correct answer. --- diff --git a/mod/quiz/report/responses/report.php b/mod/quiz/report/responses/report.php index 37f5fcc4bb..58116ac3e0 100644 --- a/mod/quiz/report/responses/report.php +++ b/mod/quiz/report/responses/report.php @@ -165,7 +165,7 @@ class quiz_responses_report extends quiz_default_report { // Print information on the grading method and whether we are displaying // if (!$table->is_downloading()) { //do not print notices when downloading - if ($strattempthighlight = quiz_report_highlighting_grading_method($quiz, $qmsubselect, $qmfilter, false)) { + if ($strattempthighlight = quiz_report_highlighting_grading_method($quiz, $qmsubselect, $qmfilter)) { echo '
' . $strattempthighlight . '
'; } } diff --git a/mod/quiz/report/responses/responsessettings_form.php b/mod/quiz/report/responses/responsessettings_form.php index f915f906a3..c77e129378 100644 --- a/mod/quiz/report/responses/responsessettings_form.php +++ b/mod/quiz/report/responses/responsessettings_form.php @@ -28,7 +28,7 @@ class mod_quiz_report_responses_settings extends moodleform { } $mform->addElement('select', 'attemptsmode', get_string('show', 'quiz_overview'), $options); if ($this->_customdata['qmsubselect']){ - $gm = quiz_get_grading_option_name($this->_customdata['quiz']->grademethod); + $gm = ''.quiz_get_grading_option_name($this->_customdata['quiz']->grademethod).''; $mform->addElement('advcheckbox', 'qmfilter', get_string('show', 'quiz_overview'), get_string('optonlygradedattempts', 'quiz_overview', $gm), null, array(0,1)); } //-------------------------------------------------------------------------------