From: toyomoyo Date: Fri, 12 Oct 2007 07:18:41 +0000 (+0000) Subject: merged fix for MDL-11717, dimmed_text class for hidden grade items in grader report X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=c1d0d07eff3fb55375a1c204b4a34d42858539f8;p=moodle.git merged fix for MDL-11717, dimmed_text class for hidden grade items in grader report --- diff --git a/grade/report/grader/lib.php b/grade/report/grader/lib.php index 82011d2f42..4fe96a66e4 100644 --- a/grade/report/grader/lib.php +++ b/grade/report/grader/lib.php @@ -575,7 +575,7 @@ class grade_report_grader extends grade_report { .$this->get_lang_string('manualgrade', 'grades') .'"/>'; } - $headerlink = $this->get_module_link($element['object']->get_name(), $itemmodule, $iteminstance); + $headerlink = $this->get_module_link($element['object']->get_name(), $itemmodule, $iteminstance, $element['object']->is_hidden()); $headerhtml .= ''. $headerlink . $arrow; $headerhtml .= $this->get_icons($element) . ''; diff --git a/grade/report/lib.php b/grade/report/lib.php index e443c7f0fd..31591958d9 100755 --- a/grade/report/lib.php +++ b/grade/report/lib.php @@ -336,9 +336,10 @@ class grade_report { * @param string $modulename The shortname of the module, will become the visible header * @param string $itemmodule The name of the module type (e.g. assignment, quiz...) * @param int $iteminstance The instance number of the module + * @param bool itemhidden - if the grade item is hidden * @return string HTML */ - function get_module_link($modulename, $itemmodule=null, $iteminstance=null) { + function get_module_link($modulename, $itemmodule=null, $iteminstance=null, $itemhidden=false) { global $CFG; $link = null; @@ -361,8 +362,11 @@ class grade_report { } $url .= "?id=$coursemodule->id"; - - return '' . $modulename . ''; + if ($itemhidden && has_capability('moodle/grade:viewhidden', get_context_instance(CONTEXT_COURSE, $coursemodule->course))) { + return '' . $modulename . ''; + } else { + return '' . $modulename . ''; + } } return $modulename;