From: donal72 <donal72>
Date: Sun, 29 Apr 2007 13:55:11 +0000 (+0000)
Subject: Bugfix: The $this->response['faultCode'] was returning the 1th element of the $this... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=c8e564f5ff6a47a93eafff3c23fba955ad508dfd;p=moodle.git

Bugfix: The $this->response['faultCode'] was returning the 1th element of the $this->response string (because a non-empty string == 1).
---

diff --git a/mnet/xmlrpc/client.php b/mnet/xmlrpc/client.php
index 8d17e2c329..deef29fa84 100644
--- a/mnet/xmlrpc/client.php
+++ b/mnet/xmlrpc/client.php
@@ -284,7 +284,7 @@ class mnet_xmlrpc_client {
         curl_close($ch);
 
         // xmlrpc errors are pushed onto the $this->error stack
-        if (isset($this->response['faultCode'])) {
+        if (is_array($this->response) && array_key_exists('faultCode', $this->response)) {
             // The faultCode 7025 means we tried to connect with an old SSL key
             // The faultString is the new key - let's save it and try again
             // The re_key attribute stops us from getting into a loop