From: sam_marshall <sam_marshall>
Date: Fri, 27 Feb 2009 14:35:05 +0000 (+0000)
Subject: MDL-18403: Completion system can cause problems if grade completion is somehow enable... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=ca6b2d6801ee8677668716d3f95ee3ff9e82b361;p=moodle.git

MDL-18403: Completion system can cause problems if grade completion is somehow enabled when completion is set to manual
---

diff --git a/lib/completionlib.php b/lib/completionlib.php
index 4f15b4e83c..b8884a3968 100644
--- a/lib/completionlib.php
+++ b/lib/completionlib.php
@@ -661,10 +661,11 @@ WHERE
     }
 
     public function inform_grade_changed($cm, $item, $grade, $deleted) {
-        // Bail out now if completion is not enabled for course-module, grade
-        // is not used to compute completion, or this is a different numbered
-        // grade
+        // Bail out now if completion is not enabled for course-module, it is enabled
+        // but is set to manual, grade is not used to compute completion, or this
+        // is a different numbered grade
         if (!$this->is_enabled($cm) ||
+            $cm->completion == COMPLETION_TRACKING_MANUAL ||
             is_null($cm->completiongradeitemnumber) ||
             $item->itemnumber != $cm->completiongradeitemnumber) {